Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine config usability enhancements for testing #69

Closed
2 tasks done
edubart opened this issue May 31, 2023 · 2 comments · Fixed by #77
Closed
2 tasks done

Machine config usability enhancements for testing #69

edubart opened this issue May 31, 2023 · 2 comments · Fixed by #77
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@edubart
Copy link
Collaborator

edubart commented May 31, 2023

Context

There are some inflexibilities in the Lua configuration that makes more boilerplate for us to create tests. Like the impossibility of creating a machine with an empty rom (we have to do tricks to create empty files), and the requirement of always needing to get flash drive length (this could be auto detected).

Definition of Done

  • Support creating a machine without a ROM image filename. ROM could still be overwritten with a memory write.
  • Allow omitting length from flash drive configs, instead fill this automatically by getting the file size.
@edubart edubart added the enhancement New feature or request label May 31, 2023
@edubart edubart self-assigned this May 31, 2023
@edubart edubart moved this to Todo in Machine Emulator SDK May 31, 2023
@edubart edubart moved this from Todo to In Progress in Machine Emulator SDK Jun 1, 2023
@edubart edubart moved this from In Progress to Done in Machine Emulator SDK Jun 6, 2023
@edubart edubart moved this from Done to Waiting Review in Machine Emulator SDK Jun 6, 2023
@edubart edubart linked a pull request Jun 6, 2023 that will close this issue
@edubart edubart moved this from Waiting Review to In Progress in Machine Emulator SDK Jun 12, 2023
@edubart edubart moved this from In Progress to Waiting Review in Machine Emulator SDK Jun 19, 2023
@edubart edubart added this to the v0.15.0 milestone Jun 28, 2023
@edubart edubart moved this from Waiting Review to Waiting Merge in Machine Emulator SDK Jul 4, 2023
@diegonehab
Copy link
Contributor

Isn't this merged already, @edubart ?

@edubart
Copy link
Collaborator Author

edubart commented Jul 17, 2023

No, it's contained in #77 , which is not merged yet because it needs more approvals.

@github-project-automation github-project-automation bot moved this from Waiting Merge to Done in Machine Emulator SDK Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants