Check end of block, update for {tinkr} expectations, add CRON #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a challenge block with three solution blocks that was
having an issue where the last solution block was not being acknowledged
as a solution block. My condition caught the block correctly (one block
with two tags), but when it went to find the correct solution block, it
got confused because it was just looking for the first block quote, so I
paramaterized it to be the first block quote that was NOT tagged.
> ## Some challenge
>
> > ## Solution 1
> > ...
> {: .solution}
>
> text ... text
>
> > ## Solution 3
> > ...
> {: .solution}
{: .challenge}
I will forever be grateful when we move away from this wretched markdown engine. For reference, I wasted an hour trying to track down a non-bug because of this: swcarpentry/r-novice-inflammation#497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes tests that were failing due to the newer version of {tinkr}, some looser expectations for Kramdown, and updates to the lesson example.
It also introduces a cron job for testing.