Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block quote formatting #497

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Fix block quote formatting #497

merged 1 commit into from
Feb 2, 2021

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Jan 27, 2021

There was a gap in the block quote, which is find for Kramdown, but not so fine for commonmark or github's markdown parser (see the same section here: https://github.com/swcarpentry/r-novice-inflammation/blob/6108ab24cee6fece6671f97ed6b8f4cfe8552ded/_episodes/11-supp-read-write-csv.md).

There was a gap in the block quote, which is find for Kramdown, but not so fine for commonmark or github's markdown parser (see the same section here: https://github.com/swcarpentry/r-novice-inflammation/blob/6108ab24cee6fece6671f97ed6b8f4cfe8552ded/_episodes/11-supp-read-write-csv.md).
zkamvar added a commit to carpentries/pegboard that referenced this pull request Jan 27, 2021
I will forever be grateful when we move away from this wretched markdown
engine. For reference, I wasted an hour trying to track down a non-bug
because of this: swcarpentry/r-novice-inflammation#497
@HaoZeke HaoZeke merged commit 9e12227 into master Feb 2, 2021
@HaoZeke HaoZeke deleted the zkamvar-patch-1 branch February 2, 2021 10:02
@HaoZeke
Copy link
Member

HaoZeke commented Feb 2, 2021

Excellent, thanks!

zkamvar pushed a commit that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants