This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: eslint migration #186
chore: eslint migration #186
Changes from 16 commits
1ed96e0
6e1f09d
69c36d6
b9e79c3
129a5fb
2749ffb
02b40a8
4320187
34574e3
7d8b762
cb200bd
4f7ef31
ab9ba0a
dd98793
7f6bdbb
77eb06e
f4a3e2a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this really the same regex without the escaping backslash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's an unnecessary escape character according to the linter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the plugin not in the latest version or does the variable set not cover block modifiers in the BEM convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our BEM convention is a mixture of
camelCase
andsnake_case
. By default, you cannot mix cases. What we could do is to write a custom regexp to support our BEM syntax...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh... that's a pity
(I don't have a valuable comment to make)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to tell without looking into the code, perhaps we can change the way we pass the props or add form the props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find a way to add a type variable to existing constructs like
forwardRef
. This causes theany
above and by consequenceany
here.