chore: eslint migration #186
Conversation
There's a bug in nodejs: nodejs/node#32107 that prevents babel 7.8.3 from working in node 13.10+ Te workaround was added in 7.8.4
This is a 3rd part intercom snippet.
| @@ -72,7 +72,7 @@ const filterOptions = (noResults) => (allOptions, text) => { | |||
| return allOptions | |||
| } | |||
|
|
|||
| const specialChars = /[-\/\\^$*+?.()|[\]{}]/g | |||
| const specialChars = /[-/\\^$*+?.()|[\]{}]/g | |||
There was a problem hiding this comment.
is this really the same regex without the escaping backslash?
There was a problem hiding this comment.
Yes, it's an unnecessary escape character according to the linter
| @@ -93,6 +93,7 @@ const Input = forwardRef<HTMLInputElement, Props>( | |||
| value={value || ""} | |||
| placeholder={placeholder || ""} | |||
| className={classNames("w-12/12", className, { | |||
| // eslint-disable-next-line @typescript-eslint/naming-convention | |||
There was a problem hiding this comment.
is the plugin not in the latest version or does the variable set not cover block modifiers in the BEM convention?
There was a problem hiding this comment.
Our BEM convention is a mixture of camelCase and snake_case. By default, you cannot mix cases. What we could do is to write a custom regexp to support our BEM syntax...
There was a problem hiding this comment.
Ugh... that's a pity
(I don't have a valuable comment to make)
| @@ -211,9 +213,11 @@ const Select = forwardRef<HTMLInputElement, Props<any>>( | |||
| <> | |||
| {"withAutosuggest" in rest && rest.withAutosuggest ? ( | |||
| <DropdownWithAutosuggest | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
There was a problem hiding this comment.
Hard to tell without looking into the code, perhaps we can change the way we pass the props or add form the props
There was a problem hiding this comment.
I did not find a way to add a type variable to existing constructs like forwardRef. This causes the any above and by consequence any here.
| @@ -7,14 +7,15 @@ import { wInfo } from "./utils" | |||
|
|
|||
| import Dropdown from "../src/components/dropdown" | |||
|
|
|||
| const options = () => object("options", [ | |||
There was a problem hiding this comment.
Do you think we need to update the code examples as the format command does not format code in comments or is it fine to have them in the old format and let one fix formatting when copying the example to the project? For me it's completely fine to keep them as is to avoid addional efforts just to update formatting in code examples.
There was a problem hiding this comment.
Oh, that's a valid point. I did not look into that...
|
🎉 This PR is included in version 6.1.0-CAR-4260-extract-header-fe37d3f547d0575fc7be01e15ab50bd541f06639.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This reverts commit 9efcdbb.
Migrate to new eslint rulest