-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Transaction metadata #372
Conversation
# Conflicts: # package.json # yarn.lock
…to feature/transaction-metadata
@DominikGuzei @rhyslbw This PR is updated with new updates for Metadata feature. Pls review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeeJayElly the build fails due to a Typescript error: https://app.netlify.com/sites/cardano-explorer-mainnet/deploys/5fbb8804c4daca000821741f
Fixed @DominikGuzei @rhyslbw |
@rhyslbw please check again - I fixed the issues I have found and looks good now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing an error:
Some transactions on the mainnet
with metadata:
43c7a108ab69847ec2bdc3e283dca65a882271a41f01b19a008043494ff128be
f910021138e553c65b96cf3e4647927fcd9f634e06544251f83cffb1891876e8
2532ea3bcb91da8b40785aa6864fc65d022757219c7d406837e50daae475f163
Also, please ensure the warning is only show if the transaction contains metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeeJayElly @rhyslbw I talked to Darko and he said this:
"For stake pools, we need it once. But for metadata every time."
So I guess we need to change the logic for transactions to show the warning every time (only for tx that have the metadata) … maybe we should make this also less intrusive? Like, showing the warning only when the user actually wants to see the metadata?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DominikGuzei @rhyslbw I have implemented the requested change. Can you guys do another round of review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good result @DeeJayElly 👍
@rhyslbw please take care of merging and deploying this change 🙏 |
Hi @DeeJayElly. For Hydra build #5131736. Looks good to me. 👍
|
Feature/Transaction metadata
Screenshots:
--
Test Cases
Scenario 1: Transaction with metadata, show
Given I am on Cardano explorer app
And default language is ‘lang’
And I have a transaction with metadata
When I search for the transaction
Then I will see a dialog titled ’title_text’
And I will see the content ‘content_text’
When I select button 'show_text'
Then the dialog will be dismissed
And Metadata will be shown
And Metadata is formatted in readable manner
Example:
Scenario 2: Transaction with metadata, leave
Given I am on Cardano explorer app
And default language is ‘lang’
And I have a transaction with metadata
When I search for the transaction
Then I will see a button 'leave_text'
When I select the button
Then the dialog will be dismissed
And I am back on Cardano App search page
Example:
Scenario 3: Transaction without metadata
Given I am on Cardano explorer app
And default language is ‘lang’
And I have a transaction without metadata
When I search for the transaction
Then I will not see a dialog titled ‘title_text’
Example:
Testing Summary
For Hydra build #5131736: