-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0024 | Adjust preamble and structure w.r.t CIP-0001 #538
CIP-0024 | Adjust preamble and structure w.r.t CIP-0001 #538
Conversation
#538 (comment) and #538 (comment) suggest we are decoupling this CIP from Daedalus, so: @KtorZ @Ryun1 - #536 puts Daedalus in the CIP Table title, and this PR puts Daedalus into the CIP document title... which reflects the way the CIP is written. If we agree that this CIP is in fact intended to apply to other wallets besides Daedalus then I'll reverse those changes here. |
I think the CIP is broader than just Daedalus. While it starts from an observation in the Daedalus' ranking, it was also written at a time were there were not as many wallets as today on Cardano. Having the CIP framed more as an alternative ranking solution would increase its chance of being adopted as I see very little chance for it being implemented by the Daedalus / cardano-wallet team after all these years. |
I see that this proposal could be generalized to other wallets, but also the author focuses solely on Daedalus. I think we can either reframe this to fit in the more general |
To be fair, the proposal doesn't focus on Daedalus, but it focuses on the official Shelley specification from which Daedalus' ranking is implemented. What it proposes, is an alternative to that ranking strategy outlines in the Shelley specs. |
ahh youre right, I had not read it carefully enough, disregard my last comment. |
some changes to CIP table have happened in master branch, which we need to modify here
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
…Daedalus Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great work @rphair 🚀
…dation#538) * cip24 update for new CIP standard * forgot to add original PR for this CIP * removing Daedalus again (CIP now broader in scope) * fix path-to-active bullets as checkboxes, broaden beyond Daedalus Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com> * (continued) fix path-to-active bullets as checkboxes, broaden beyond Daedalus Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com> --------- Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
…dation#538) * cip24 update for new CIP standard * forgot to add original PR for this CIP * removing Daedalus again (CIP now broader in scope) * fix path-to-active bullets as checkboxes, broaden beyond Daedalus Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com> * (continued) fix path-to-active bullets as checkboxes, broaden beyond Daedalus Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com> --------- Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Fixes #534.
Completes CIP title update begun in #536.