Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0024 | Adjust preamble and structure w.r.t CIP-0001 #538

Merged
merged 6 commits into from
Jul 6, 2023

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Jul 2, 2023

Fixes #534.
Completes CIP title update begun in #536.

@rphair rphair added the Update Adds content or significantly reworks an existing proposal label Jul 2, 2023
@rphair rphair requested review from SebastienGllmt, KtorZ and Ryun1 July 2, 2023 12:45
CIP-0024/README.md Outdated Show resolved Hide resolved
CIP-0024/README.md Outdated Show resolved Hide resolved
@rphair
Copy link
Collaborator Author

rphair commented Jul 4, 2023

#538 (comment) and #538 (comment) suggest we are decoupling this CIP from Daedalus, so:

@KtorZ @Ryun1 - #536 puts Daedalus in the CIP Table title, and this PR puts Daedalus into the CIP document title... which reflects the way the CIP is written. If we agree that this CIP is in fact intended to apply to other wallets besides Daedalus then I'll reverse those changes here.

@KtorZ
Copy link
Member

KtorZ commented Jul 4, 2023

I think the CIP is broader than just Daedalus. While it starts from an observation in the Daedalus' ranking, it was also written at a time were there were not as many wallets as today on Cardano.

Having the CIP framed more as an alternative ranking solution would increase its chance of being adopted as I see very little chance for it being implemented by the Daedalus / cardano-wallet team after all these years.

@Ryun1
Copy link
Collaborator

Ryun1 commented Jul 4, 2023

I see that this proposal could be generalized to other wallets, but also the author focuses solely on Daedalus.

I think we can either reframe this to fit in the more general wallets category OR we set to status of inactive as Deadalus is not an enlisted CIP category.

@KtorZ
Copy link
Member

KtorZ commented Jul 4, 2023

To be fair, the proposal doesn't focus on Daedalus, but it focuses on the official Shelley specification from which Daedalus' ranking is implemented. What it proposes, is an alternative to that ranking strategy outlines in the Shelley specs.

@Ryun1
Copy link
Collaborator

Ryun1 commented Jul 4, 2023

but it focuses on the official Shelley specification

ahh youre right, I had not read it carefully enough, disregard my last comment.

@rphair
Copy link
Collaborator Author

rphair commented Jul 4, 2023

good @KtorZ @Ryun1, we're in agreement then ... I'll commit a further change that removes the Daedalus term again from both titles.

rphair and others added 4 commits July 4, 2023 16:48
some changes to CIP table have happened in master branch, which we need to modify here
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
…Daedalus

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
@rphair
Copy link
Collaborator Author

rphair commented Jul 6, 2023

OK @Ryun1 that's been done a couple days ago... can we have another look? 🤠 (also at #537 please)

Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great work @rphair 🚀

@rphair rphair merged commit 5968378 into cardano-foundation:master Jul 6, 2023
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Jul 28, 2023
…dation#538)

* cip24 update for new CIP standard

* forgot to add original PR for this CIP

* removing Daedalus again (CIP now broader in scope)

* fix path-to-active bullets as checkboxes, broaden beyond Daedalus

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>

* (continued) fix path-to-active bullets as checkboxes, broaden beyond Daedalus

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>

---------

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
…dation#538)

* cip24 update for new CIP standard

* forgot to add original PR for this CIP

* removing Daedalus again (CIP now broader in scope)

* fix path-to-active bullets as checkboxes, broaden beyond Daedalus

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>

* (continued) fix path-to-active bullets as checkboxes, broaden beyond Daedalus

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>

---------

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Adds content or significantly reworks an existing proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIP-0024 | Adjust preamble and structure w.r.t CIP-0001
3 participants