Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0007 | Adjust preamble and structure w.r.t CIP-0001 #537

Merged
merged 5 commits into from
Jul 6, 2023

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Jul 2, 2023

Fixes #532.

@KtorZ please check the Path to Active is OK here is OK before I might also apply the same Acceptance Criteria in #533 & #535.

@rphair rphair added the Update Adds content or significantly reworks an existing proposal label Jul 2, 2023
@rphair rphair requested review from KtorZ and Ryun1 July 2, 2023 12:20
CIP-0007/README.md Show resolved Hide resolved
CIP-0007/README.md Outdated Show resolved Hide resolved
CIP-0007/README.md Outdated Show resolved Hide resolved
rphair and others added 3 commits July 4, 2023 15:30
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
… Implementation, not Acceptance

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
@rphair
Copy link
Collaborator Author

rphair commented Jul 4, 2023

@KtorZ just to be sure I follow a correct process for the remaining RSS proposals: why does your last suggested change place:

The new equation is implemented in the ledger and enacted through a hard-fork.

(in Acceptance Criteria) before

Agreement by the Ledger team ... on changes to rewards & incentives.

(in Implementation Plan)? I must be missing something, but mustn't the agreement to make the change precede the actual implementation? And why in this particular case have we placed the implementation of the new rewards equation in the Acceptance criteria?

@KtorZ
Copy link
Member

KtorZ commented Jul 4, 2023

Acceptance criteria is what indicates how a CIP moves from proposed to active, so almost everytime, it comes AFTER the implementation. Acceptance criteria isn't a signal for the implementation to start; rather, it signals that a CIP is actually "final". It's been implemented and there are observable metrics that can vouch for it.

Hence why most ledger CIPs end up with "implemented in the ledger and enacted through hard-fork" as acceptance criteria. Same for Plutus changes, acceptance criteria usually states that there's a new plutus version that include the new features.

The implementation plan relates to how we get from proposed to active; hence, in my opinion, part of the plan is indeed to get approval from the relevant teams / experts (which is kind of implicit to the CIP process and the registered categories).

@rphair
Copy link
Collaborator Author

rphair commented Jul 4, 2023

@KtorZ thanks for the confirmation... I was just getting around to that understanding from going back & reading CIP-0001 in the last half-hour. I had been under the false impression that acceptance would have to proceed implementation so that these two sections would be in roughly chronological order: I can see now that they can proceed in parallel and often in reverse order. 👌

Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤓

@rphair rphair merged commit 421e644 into cardano-foundation:master Jul 6, 2023
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Jul 28, 2023
…dation#537)

* cip7 update for new CIP standard

* forgot to apply the new Authors: format

* missed a single-element list (breaking into bullets)

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>

* new Ledger RSS criteria; fill out into bullets with checkboxes

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>

* checkboxes all through Plan to Active; RSS Ledger approval is part of Implementation, not Acceptance

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>

---------

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
…dation#537)

* cip7 update for new CIP standard

* forgot to apply the new Authors: format

* missed a single-element list (breaking into bullets)

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>

* new Ledger RSS criteria; fill out into bullets with checkboxes

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>

* checkboxes all through Plan to Active; RSS Ledger approval is part of Implementation, not Acceptance

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>

---------

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Adds content or significantly reworks an existing proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIP-0007 | Adjust preamble and structure w.r.t CIP-0001
3 participants