-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0007 | Adjust preamble and structure w.r.t CIP-0001 #537
CIP-0007 | Adjust preamble and structure w.r.t CIP-0001 #537
Conversation
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
… Implementation, not Acceptance Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
@KtorZ just to be sure I follow a correct process for the remaining RSS proposals: why does your last suggested change place:
(in Acceptance Criteria) before
(in Implementation Plan)? I must be missing something, but mustn't the agreement to make the change precede the actual implementation? And why in this particular case have we placed the implementation of the new rewards equation in the Acceptance criteria? |
Acceptance criteria is what indicates how a CIP moves from Hence why most ledger CIPs end up with "implemented in the ledger and enacted through hard-fork" as acceptance criteria. Same for Plutus changes, acceptance criteria usually states that there's a new plutus version that include the new features. The implementation plan relates to how we get from |
@KtorZ thanks for the confirmation... I was just getting around to that understanding from going back & reading CIP-0001 in the last half-hour. I had been under the false impression that acceptance would have to proceed implementation so that these two sections would be in roughly chronological order: I can see now that they can proceed in parallel and often in reverse order. 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤓
…dation#537) * cip7 update for new CIP standard * forgot to apply the new Authors: format * missed a single-element list (breaking into bullets) Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com> * new Ledger RSS criteria; fill out into bullets with checkboxes Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com> * checkboxes all through Plan to Active; RSS Ledger approval is part of Implementation, not Acceptance Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com> --------- Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
…dation#537) * cip7 update for new CIP standard * forgot to apply the new Authors: format * missed a single-element list (breaking into bullets) Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com> * new Ledger RSS criteria; fill out into bullets with checkboxes Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com> * checkboxes all through Plan to Active; RSS Ledger approval is part of Implementation, not Acceptance Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com> --------- Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Fixes #532.
@KtorZ please check the Path to Active is OK here is OK before I might also apply the same Acceptance Criteria in #533 & #535.