feat(tearsheet): change icondescription prop to optional #6662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
davidmenendez
previously requested changes
Jan 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6662 +/- ##
==========================================
+ Coverage 80.69% 80.71% +0.02%
==========================================
Files 397 397
Lines 12940 12938 -2
Branches 4291 4292 +1
==========================================
+ Hits 10442 10443 +1
+ Misses 2498 2495 -3
|
Thanks @davidmenendez. |
AlexanderMelox
requested changes
Jan 7, 2025
AlexanderMelox
approved these changes
Jan 13, 2025
devadula-nandan
approved these changes
Jan 15, 2025
This is already fixed.
Merged
via the queue into
carbon-design-system:main
with commit Jan 15, 2025
5ba3e04
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6276
closeIconDescriptionon the Tearsheet component has been made optional to align with core Carbon Modal.What did you change?
How did you test and verify your work?