Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can props.closeIconDescription on Tearsheet be made optional in accordance to core Carbon? #6276

Closed
2 tasks done
janhassel opened this issue Oct 23, 2024 · 0 comments · Fixed by #6662
Closed
2 tasks done

Can props.closeIconDescription on Tearsheet be made optional in accordance to core Carbon? #6276

janhassel opened this issue Oct 23, 2024 · 0 comments · Fixed by #6662
Assignees
@sangeethababu9223
Labels
component: Tearsheet priority: low This can wait to be picked up role: dev type: enhancement 💡 New feature or request

Comments

@janhassel
Copy link
Member

Summary

Currently, props.closeIconDescription is marked as required if a Tearsheet has a close button. This deviates from the underlying ModalHeader component from core Carbon which marks props.iconDescription as optional as it has a sensible default.

Can this validation be updated to align with core Carbon?

Relevant information

No response

Name and organization

Code of Conduct
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Oct 23, 2024
@ljcarot ljcarot moved this from Needs triage 🧐 to Backlog 🌋 in Carbon for IBM Products Oct 28, 2024
@ljcarot ljcarot added type: enhancement 💡 New feature or request and removed type: question ❓ Further information is requested labels Oct 28, 2024
@elycheea elycheea added role: dev priority: low This can wait to be picked up labels Oct 28, 2024
@sangeethababu9223 sangeethababu9223 self-assigned this Jan 6, 2025
@sangeethababu9223 sangeethababu9223 moved this from Backlog 🌋 to In progress in Carbon for IBM Products Jan 6, 2025
@sangeethababu9223 sangeethababu9223 mentioned this issue Jan 6, 2025
Merged
@sangeethababu9223 sangeethababu9223 moved this from In progress to Needs review 👋 in Carbon for IBM Products Jan 7, 2025
@github-project-automation github-project-automation bot moved this from Needs review 👋 to Done 🚀 in Carbon for IBM Products Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangeethababu9223 sangeethababu9223

Labels
component: Tearsheet priority: low This can wait to be picked up role: dev type: enhancement 💡 New feature or request
Projects
Carbon for IBM Products
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(tearsheet): change icondescription prop to optional sangeethababu9223/ibm-products
5 participants
@elycheea @ljcarot @janhassel @oliviaflory @sangeethababu9223