Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(useFocus): refactor repeated useEffect code #6459

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

makafsal
Copy link
Member

Closes #6420

What did you change?

Refactored the common useEffect logic into a single claimFocus common method

How did you test and verify your work?

yarn avt
yarn test
storybook

@makafsal makafsal requested a review from a team as a code owner November 18, 2024 12:42
@makafsal makafsal requested review from matthewgallo and sangeethababu9223 and removed request for a team November 18, 2024 12:42
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 08d4589
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/673c1f004ab2230008cfaecb
😎 Deploy Preview https://deploy-preview-6459--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 08d4589
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/673c1f003003fe0008009538
😎 Deploy Preview https://deploy-preview-6459--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.63%. Comparing base (1f5b63e) to head (cf72a26).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6459      +/-   ##
==========================================
+ Coverage   79.61%   79.63%   +0.02%     
==========================================
  Files         394      394              
  Lines       12871    12856      -15     
  Branches     4268     4257      -11     
==========================================
- Hits        10247    10238       -9     
+ Misses       2624     2618       -6     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@elycheea elycheea added this pull request to the merge queue Nov 21, 2024
Merged via the queue into carbon-design-system:main with commit 0cf0f70 Nov 21, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor the useEffect used to invoke useFocus in various components
4 participants