Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the useEffect used to invoke useFocus in various components #6420

Closed
2 tasks done
makafsal opened this issue Nov 13, 2024 · 0 comments · Fixed by #6459
Closed
2 tasks done

refactor the useEffect used to invoke useFocus in various components #6420

makafsal opened this issue Nov 13, 2024 · 0 comments · Fixed by #6459
Assignees
@makafsal
Labels
role: dev Sev 4 Not visible to or noticeable to users. Affects minor functionality, no workaround needed.

Comments

@makafsal
Copy link
Member

makafsal commented Nov 13, 2024 •
edited
Loading

From @matthewgallo 's comment from the PR

Since we now have a very similar useEffect here and in TearsheetShell, we should think about putting this inside a custom hook that is used in both components. I don't want to hold up this PR longer, so lets look at that after we get this merged.

Create a custom hook to use across components those having similar useEffect for the useFocus hook.

Identified components:

  • TearsheetShell
  • APIKeyModal
@makafsal makafsal self-assigned this Nov 13, 2024
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Nov 13, 2024
@makafsal makafsal added Sev 4 Not visible to or noticeable to users. Affects minor functionality, no workaround needed. role: dev and removed status: needs triage 🕵️‍♀️ labels Nov 13, 2024
@amal-k-joy amal-k-joy changed the title refactor the useEffect used to invoke useFocus is various components refactor the useEffect used to invoke useFocus in various components Nov 13, 2024
@makafsal makafsal moved this from Needs refinement 🤓 to Backlog 🌋 in Carbon for IBM Products Nov 13, 2024
@makafsal makafsal mentioned this issue Nov 18, 2024
Merged
@makafsal makafsal moved this from Backlog 🌋 to In progress in Carbon for IBM Products Nov 18, 2024
@matthewgallo matthewgallo moved this from Needs review 👋 to In review 👀 in Carbon for IBM Products Nov 20, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🚀 in Carbon for IBM Products Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@makafsal makafsal

Labels
role: dev Sev 4 Not visible to or noticeable to users. Affects minor functionality, no workaround needed.
Projects
Carbon for IBM Products
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(useFocus): refactor repeated useEffect code makafsal/ibm-products
1 participant
@makafsal