fix(Datagrid): resolve CSP in subcomponents #6229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
elycheea
reviewed
Oct 17, 2024
packages/ibm-products/src/components/Datagrid/utils/DatagridActions.js
Outdated
Show resolved
Hide resolved
elycheea
approved these changes
Oct 18, 2024
sangeethababu9223
approved these changes
Oct 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6229 +/- ##
=======================================
Coverage 78.68% 78.69%
=======================================
Files 395 395
Lines 12794 12793 -1
Branches 4214 4212 -2
=======================================
Hits 10067 10067
+ Misses 2727 2726 -1
|
Merged
via the queue into
carbon-design-system:main
with commit Oct 21, 2024
95c6489
23 checks passed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing 2 files from 6189
Replaced inline style in DatagridExpandedRow.tsx
Removed styles from DatagridActions.js since its not getting applied anywhere
What did you change?
packages/ibm-products/src/components/Datagrid/utils/DatagridActions.js
packages/ibm-products/src/components/Datagrid/Datagrid/DatagridExpandedRow.tsx
How did you test and verify your work? storybook