Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CSP in Datagrid subcomponents #6189

Closed
2 of 5 tasks
elycheea opened this issue Oct 8, 2024 · 2 comments
Closed
2 of 5 tasks

Address CSP in Datagrid subcomponents #6189

elycheea opened this issue Oct 8, 2024 · 2 comments
Assignees

Comments

@elycheea
Copy link
Contributor

elycheea commented Oct 8, 2024

DatagridActions.js is negotiable. It’s meant to be an example, but we have heard instances where consumers will try to import this to use anyway.

  • Include the respective component name in the forbid configuration inside package.json
  • Run yarn lint and fix the errors
  • Replace style={{}} usage with classNames where appropriate
  • Set dynamic styles using useIsomorphicEffect()

Tasks

Preview Give feedback
@anamikaanu96
Copy link
Contributor

anamikaanu96 commented Oct 16, 2024

DatagridRow.tsx -> For implementing forwardRef in TableCell I have raised a PR in carbon for issue

@anamikaanu96
Copy link
Contributor

anamikaanu96 commented Oct 22, 2024

Two tasks(DatagridExpandedRow.tsx and DatagridActions.js) in this ticket is already merged with PR.

As discussed for below tasks I have opened separate tickets and closing this issue.

@github-project-automation github-project-automation bot moved this from In progress to Done 🚀 in Carbon for IBM Products Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants