Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forwardref added in tablecell #17760

Merged

Conversation

anamikaanu96
Copy link
Contributor

Closes #17759

Implemented forwardRef in TableCell

Changelog

New

  • Added forwardref to TableCell

Testing / Reviewing

storybook

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner October 16, 2024 09:33
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 3e7bf51
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67108c4dbc02000008a409c1
😎 Deploy Preview https://deploy-preview-17760--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3e7bf51
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67108c4d5038110008733fbf
😎 Deploy Preview https://deploy-preview-17760--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo
Copy link
Member

Looks like the forwarded ref still needs to be passed to the td element.

@2nikhiltom
Copy link
Contributor

Hey @anamikaanu96 ! This looks good, just one CI check is failing !
you will need to run "yarn test -u" and commit the snapshot changes

Also it would be great if we can have a test case for this
example


 it('should forward refs to the rendered SVG DOM element', () => {
    let svg;
    const ref = jest.fn((node) => {
      svg = node;
    });
    const { container } = render(<Icon ref={ref} />);
    expect(svg).toEqual(container.querySelector('svg'));
  });

@tay1orjones tay1orjones added the status: needs tests PRs that need tests label Oct 16, 2024
@anamikaanu96 anamikaanu96 requested a review from a team as a code owner October 17, 2024 03:54
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 3e7bf51
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67108c4d5b59fd0008e71be5
😎 Deploy Preview https://deploy-preview-17760--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (d5ae548) to head (3e7bf51).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17760   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files         406      406           
  Lines       14019    14019           
  Branches     4336     4384   +48     
=======================================
  Hits        11154    11154           
  Misses       2700     2700           
  Partials      165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Merged via the queue into carbon-design-system:main with commit e840ffd Oct 17, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Implement forwardRef in TableCell
7 participants