Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EditInPlace): removes focus when pressing esc or enter key #5943

Merged
merged 2 commits into from
Aug 28, 2024
+7 −4
Merged

fix(EditInPlace): removes focus when pressing esc or enter key #5943

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3252798
fix(EditInPlace): removes focus when pressing esc or enter key
AlexanderMelox Aug 26, 2024
62cd8f2
fix: remove focus state on functions
AlexanderMelox Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/ibm-products/src/components/EditInPlace/EditInPlace.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,16 +248,21 @@ export let EditInPlace = forwardRef<HTMLDivElement, EditInplaceProps>(
onCancelHandler();
};

const removeFocus = () => {
amal-k-joy marked this conversation as resolved.
Show resolved Hide resolved
inputRef.current?.blur();
setFocused(false);
};

const onKeyHandler = (e) => {
// to prevent blur handler from being called twice add additional state to check if escape is being used
escaping.current = true;
switch (e.key) {
case 'Escape':
inputRef.current?.blur();
removeFocus();
escapeHandler();
break;
case 'Enter':
inputRef.current?.blur();
removeFocus();
returnHandler();
break;
default:
Expand Down
Loading