Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EditInPlace): removes focus when pressing esc or enter key #5943

Conversation

AlexanderMelox
Copy link
Contributor

Closes #5852

This PR removes the focus of the EditInPlace after pressing Enter or the Escape key.

What did you change?

packages/ibm-products/src/components/EditInPlace/EditInPlace.tsx

How did you test and verify your work?

Modified storybook story to reflect the code sandbox props

Screen.Recording.2024-08-26.at.11.41.25.AM.mov

@AlexanderMelox AlexanderMelox requested a review from a team as a code owner August 26, 2024 15:47
@AlexanderMelox AlexanderMelox requested review from makafsal and amal-k-joy and removed request for a team August 26, 2024 15:47
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 62cd8f2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66ce2f4e4706910009587f9c
😎 Deploy Preview https://deploy-preview-5943--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo matthewgallo added this pull request to the merge queue Aug 28, 2024
Merged via the queue into carbon-design-system:main with commit 5eff024 Aug 28, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EditInPlace keeps focused state when invalid but field is not actually focused on
4 participants