Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ProductiveCard): with overflow tooltip issue #5803

Merged
merged 4 commits into from
Aug 7, 2024
Merged

fix(ProductiveCard): with overflow tooltip issue #5803

merged 4 commits into from
Aug 7, 2024

Conversation

sangeethababu9223
Copy link
Member

Closes #5399

No option to edit tooltip text on ProductiveCard with Overflow menu

What did you change?

Added iconDescription attribute to ProductiveCard and passes the same as prop to CardHeader.

How did you test and verify your work?

Storybook

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner August 5, 2024 10:16
@sangeethababu9223 sangeethababu9223 requested review from kennylam and amal-k-joy and removed request for a team August 5, 2024 10:16
@netlify Netlify
Copy link

netlify bot commented Aug 5, 2024 •
edited
Loading

✅ Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit c0f61a3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66b1fa4bf84e2600087320e6
😎 Deploy Preview https://deploy-preview-5803--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@szinta szinta self-requested a review August 6, 2024 05:42
szinta
szinta reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@szinta szinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion added for setting the default value. Except that LGTM.

packages/ibm-products/src/components/Card/Card.tsx Outdated Show resolved Hide resolved
amal-k-joy
amal-k-joy approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangeethababu9223 sangeethababu9223 added this pull request to the merge queue Aug 7, 2024
Merged via the queue into carbon-design-system:main with commit 413b210 Aug 7, 2024
19 checks passed
@sangeethababu9223 sangeethababu9223 deleted the fix/productive-card-overflow-menu-tooltip-issue branch August 7, 2024 04:49
@devadula-nandan devadula-nandan mentioned this pull request Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amal-k-joy amal-k-joy amal-k-joy approved these changes

@szinta szinta szinta approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-products-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to edit tooltip text on ProductiveCard with Overflow menu
3 participants
@sangeethababu9223 @szinta @amal-k-joy