Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to edit tooltip text on ProductiveCard with Overflow menu #5399

Closed
1 task
adamlsmith981 opened this issue Jun 4, 2024 · 4 comments · Fixed by #5803
Closed
1 task

unable to edit tooltip text on ProductiveCard with Overflow menu #5399

adamlsmith981 opened this issue Jun 4, 2024 · 4 comments · Fixed by #5803
Assignees
Labels
component: Card role: dev Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. type: bug 🐛 Something isn't working

Comments

@adamlsmith981
Copy link
Contributor

adamlsmith981 commented Jun 4, 2024

Package

Carbon for IBM Products

Description

I have been working on an issue migrating our project to carbon 11, and I can't seem to use the overflowAriaLabel to replace the default value of "Options".

Component(s) impacted

ProductiveCard

Browser

Chrome, Firefox

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

v2.38.0

Severity

Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.

Product/offering

IBM Event Endpoint Management

CodeSandbox or Stackblitz example

https://carbon-for-ibm-products.netlify.app/?path=/story/ibm-products-components-cards-productivecard--with-overflow

Steps to reproduce the issue (if applicable)

add the prop / change the control overflowAriaLabel="Something else on storybook

https://carbon-for-ibm-products.netlify.app/?path=/story/ibm-products-components-cards-productivecard--with-overflow

Release date (if applicable)

No response

Code of Conduct

Tasks

Preview Give feedback
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Jun 4, 2024
@matthewgallo matthewgallo added type: bug 🐛 Something isn't working Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. component: Card and removed status: needs triage 🕵️‍♀️ labels Jun 10, 2024
@matthewgallo matthewgallo moved this from Needs triage 🧐 to Needs refinement 🤓 in Carbon for IBM Products Jun 10, 2024
@devadula-nandan
Copy link
Contributor

Hey @adamlsmith981,
i could see the overflowAriaLabel prop being passed by the value we set, as intended, as shown in the screenshot, could you check it?

Image

@devadula-nandan devadula-nandan removed type: bug 🐛 Something isn't working Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. labels Jun 17, 2024
@adamlsmith981
Copy link
Contributor Author

Ah perhaps this isn't working as I hope it would do then, which was that it was supposed to update the value of the tool tip on the the overflow menu button, which seems to have a default value of Options. But yes, I am agreeable that that prop is updating the aria-label in the component in the dom.

So my issue would update to: how can I override the tooltip text Options that would appear over the overflow menu button? This doesn't look to be exposed as a updatable prop from what I can see? Thanks for your help in advance! :)

@adamlsmith981 adamlsmith981 changed the title overflowAriaLabel prop in ProductiveCard not working unable to edit tooltip text on ProductiveCard with Overflow menu Jul 23, 2024
@adamlsmith981
Copy link
Contributor Author

Just want to bump this issue, I am unable to find a way to override the Options text on the overflow menu tooltip. Is there any chance that this could be implemented if it does not exist already?
image

@elycheea
Copy link
Contributor

@adamlsmith981 @devadula-nandan Looks like the default is actually coming from the Carbon component and we’d need to add iconDescription to our CardHeader for us to be able to update this.

@elycheea elycheea moved this from Needs refinement 🤓 to Backlog 🌋 in Carbon for IBM Products Jul 24, 2024
@elycheea elycheea added type: bug 🐛 Something isn't working Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. labels Jul 24, 2024
@sangeethababu9223 sangeethababu9223 self-assigned this Aug 5, 2024
@sangeethababu9223 sangeethababu9223 moved this from Backlog 🌋 to In progress in Carbon for IBM Products Aug 5, 2024
@sangeethababu9223 sangeethababu9223 moved this from In progress to Needs review 👋 in Carbon for IBM Products Aug 5, 2024
@github-project-automation github-project-automation bot moved this from Needs review 👋 to Done 🚀 in Carbon for IBM Products Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Card role: dev Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. type: bug 🐛 Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants