-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add shadow token, update overlay token #9812
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 5895656 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615f5a2e4351600007448933 😎 Browse the preview: https://deploy-preview-9812--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 5895656 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615f5a2ea1dc350008dcc36f 😎 Browse the preview: https://deploy-preview-9812--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 5895656 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615f5a2eef00bb00087c4e57 😎 Browse the preview: https://deploy-preview-9812--carbon-components-react.netlify.app |
My bad, I thought it was 0.7, but I just checked the Color Guidelines and it is 0.5—Let's keep this way
Here I was using as reference the Style infos on the Overflow menu that states it is 0.3—if it was not I assume it was a bug. |
That's probably a mistake on the documentation then as both components use the same code under the hood to display their box shadow. I agree that 0.3 seems better. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay for making these tokens! And yeah I think @yumeforever has got you the right values. Thank you for making this PR!!! And thanks Morgana for doing the design leg work on this one. We really appreciate y'alls contribution.
PS Design team talked about this off-line and gave the thumbs up from our perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @janhassel!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 thanks for adding this!!!!
Closes #9802
Changelog
New
shadow
rgba(0, 0, 0, 0.3)
rgba(0, 0, 0, 0.8)
Changed
overlay
/overlay-01
tokenrgba(0, 0, 0, 0.65)
Testing / Reviewing
overlay
/overlay-01
token in light themes should've beenrgba(gray100, 0.7)
though it beingrgba(gray100, 0.5)
. Which one is preferred?rgba(0, 0, 0, 0.3)
though it wasrgba(0, 0, 0, 0.2)
. I changed it to @yumeforever's suggestion to increase the contrast. Let me know if this works for everyone.