Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Improve contrast on shadows for dark themes (G90 and G100) #9802

Closed
3 tasks done
yumeforever opened this issue Oct 5, 2021 · 3 comments · Fixed by #9812
Closed
3 tasks done

[Feature Request]: Improve contrast on shadows for dark themes (G90 and G100) #9802

yumeforever opened this issue Oct 5, 2021 · 3 comments · Fixed by #9812
Labels
proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 status: waiting for author's response 💬 type: enhancement 💡

Comments

@yumeforever
Copy link

yumeforever commented Oct 5, 2021 •
edited
Loading

Summary

Based on our conversations about the Side Panels and increasing contrast on dark mode shadows to match the contrast level of Light Themes (White and G10), I want to propose some changes to these components.

Overflow menu shadows

  • Either changing both to 80% opacity OR G90 to 70% and g100 to 80%

Page overlay for Modals

  • Overlay color change to #000000 (instead of #161616) and transparency of 65%

image

image

Justification

No response

Desired UX and success metrics

No response

Required functionality

No response

Specific timeline issues / requests

IBM Cloud is rolling out Dark Mode to clients until next January, product teams are already fixing their code bases to use Carbon Themes correctly. It would be essential this update is ready by the end of the year.

Available extra resources

No response

Code of Conduct
@yumeforever
Copy link
Author

Oh! I just realize the Dropdown would probably need the same treatment :)

@tay1orjones tay1orjones added the proposal: open This request has gone through triaging. We're determining whether we take this on or not. label Oct 6, 2021
@tay1orjones
Copy link
Member

cc @carbon-design-system/design

@janhassel janhassel mentioned this issue Oct 6, 2021
Merged
@aagonzales aagonzales added proposal: accepted This request has gone through triaging and we are accepting PR's against it. and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Oct 7, 2021
@aagonzales
Copy link
Member

Accepting this proposal, we talked about this in slack and it has the 👍

@kodiakhq kodiakhq bot closed this as completed in #9812 Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 status: waiting for author's response 💬 type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add shadow token, update overlay token janhassel/carbon
3 participants
@tay1orjones @yumeforever @aagonzales