Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pagination-nav): sass module refactor #9076

Merged
merged 4 commits into from
Jul 1, 2021
Merged

feat(pagination-nav): sass module refactor #9076

merged 4 commits into from
Jul 1, 2021

Conversation

andreancardona
Copy link
Contributor

Closes #9068

  • Refactors PaginationNav to SASS modules

Testing:

  • run yarn test --watch packages/styles/scss/components/__tests__/pagination-nav-test.js
  • Make sure tests pass
  • cd packages/carbon-react run yarn storybook to make sure none of the styles are broken for PaginationNav

@andreancardona andreancardona requested a review from a team as a code owner June 30, 2021 16:46
@andreancardona andreancardona changed the title 9068 pagination sass refactor feat(pagination-nav): sass module refactor Jun 30, 2021
@andreancardona andreancardona mentioned this pull request Jun 30, 2021
Closed
62 tasks
@netlify
Copy link

netlify bot commented Jun 30, 2021 •
edited
Loading

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 0c94f86

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60ddc6bbe047ff094c2ace5d

@netlify
Copy link

netlify bot commented Jun 30, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 0c94f86

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60dd302a36147c00082e4606

😎 Browse the preview: https://deploy-preview-9076--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 30, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0c94f86

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60dd302a8d80a80007202ccf

😎 Browse the preview: https://deploy-preview-9076--carbon-components-react.netlify.app

tw15egan
tw15egan approved these changes Jul 1, 2021
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@sstrubberg sstrubberg merged commit 5e6f937 into carbon-design-system:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@tw15egan tw15egan tw15egan approved these changes

@emyarod emyarod Awaiting requested review from emyarod

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination Nav SASS Refactor
3 participants
@andreancardona @tw15egan @sstrubberg