Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination Nav SASS Refactor #9068

Closed
3 tasks
andreancardona opened this issue Jun 30, 2021 · 0 comments · Fixed by #9076
Closed
3 tasks

Pagination Nav SASS Refactor #9068

andreancardona opened this issue Jun 30, 2021 · 0 comments · Fixed by #9076

Comments

@andreancardona
Copy link
Contributor

andreancardona commented Jun 30, 2021

This issue is for updating the Notification to Sass Modules in the @carbon/styles package. In this refactor, we will:

  • Copy over styles for for the component to packages/styles/scss/components/floating-menu/_pagination-nav/scss
    • Any additional files will live in the folder packages/styles/scss/components/pagination-nav/
  • Create an _index.scss at packages/styles/scss/components/pagination-nav/_index.scss
  • Create a test file at packages/styles/scss/components/__tests__/pagination-nav/-test.js

The _index.scss should:

  • @forward the mixin and any variables from _pagination-nav/.scss
  • Include the styles from _pagination-nav/.scss by calling the mixin

The pagination-nav/-test.js file should test the following:

  • The Public API of the pagination-nav/_index.scss file
  • Any configuration options that are present for the file

The _pagination-nav/.scss will then need to be refactored to use the new import paths and conventions. You can find common recipes here: #8899 (comment)

If your component includes component tokens, follow the instructions below 👇

Component tokens
  • Copy over the _tokens.scss file for the component to scss/components/<component>/_tokens.scss
  • Change any tokens to their new paths, common changes that need to happen will be if the token map uses IDL colors or token colors. These now come from scss/_colors.scss and scss/_theme.scss specifically.
  • Bring in scss/utilities/_component-tokens.scss file
  • Use this utility to generate four exports in _tokens.scss: $white, $g10, $g90, and $g100
  • Each export should look like the following: $white: component-tokens.get-tokens($-tokens, themes.$white);
  • Add the tokens to the component exports in scss/components/<component>/_index.scss by using @forward 'tokens'
  • If using storybook, update packages/carbon-react/.storybook/styles.scss to include the new component tokens for each theme. This will look like:
@use '../scss/components/notification';

:root {
  @include styles.theme(themes.$white, notification.$white);
}

.g10 {
  // ...
}

You may also need to add the entrypoint in the @carbon/react package itself at packages/carbon-react/scss/components/<component>/_index.scss

@andreancardona andreancardona changed the title Floating menu SASS Refactor Toolbar SASS Refactor Jun 30, 2021
@andreancardona andreancardona changed the title Toolbar SASS Refactor Pagination Nav SASS Refactor Jun 30, 2021
@tw15egan tw15egan mentioned this issue Jun 30, 2021
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants