fix(toggle): update disabled toggle tokens #8514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 3b3761e |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 3b3761e https://deploy-preview-8514--carbon-components-react.netlify.app |
|
@aagonzales just to follow up on @tw15egan's question in the ticket, should we be using new token names here? |
|
oh uh I guess so? It would be |
a448d36 to
e03f919
Compare
andreancardona
approved these changes
Apr 28, 2021
tay1orjones
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6794
This PR updates the disabled toggle color tokens so that the tokens used for toggles within data tables is now the default
Testing / Reviewing
Confirm the new disabled token colors match the updated spec