Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'light' prop to Toggle #5932

Closed
clarebyrne opened this issue Apr 24, 2020 · 5 comments
Closed

Add 'light' prop to Toggle #5932

clarebyrne opened this issue Apr 24, 2020 · 5 comments

Comments

@clarebyrne
Copy link

Detailed description

Describe in detail the issue you're having.
Need to add light={true} prop to a toggle component.
eg. see TextArea component, has 'light' prop

Is this issue related to a specific component?
-Toggle
-ToggleSmall

What did you expect to happen? What happened instead? What would you like to
see changed?
Need to add prop for component to display correctly on a light background

Additional information

Screenshot showing that toggles on light background do not display correctly

  • Screenshots or code

toggleimage

  • Notes
@emyarod
Copy link
Member

emyarod commented Apr 24, 2020

cc @carbon-design-system/design do we have a spec for themed toggles?

@tw15egan
Copy link
Collaborator

tw15egan commented Apr 24, 2020

It seems like if we add a light variation we could simply swap disabled-01 / disabled-02 on the ::before / ::after. The normal appearance does not seem to have any issues, just when the toggle is disabled.

Screen Shot 2020-04-24 at 10 08 26 AM

@asudoh
Copy link
Contributor

asudoh commented Apr 24, 2020

CC @carbon-design-system/design to see their input.

@aagonzales
Copy link
Member

We're looking into it. We might be adjusting the tokens vs adding a light prop. We'll report back.

@aagonzales
Copy link
Member

Has been fixed in this PR: #8514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants