-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pagination): prevent page controls from stacking vertically #7427
fix(pagination): prevent page controls from stacking vertically #7427
Conversation
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: 4a4cd3f 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd275a78c2439000835382b 😎 Browse the preview: https://deploy-preview-7427--carbon-elements.netlify.app |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 4a4cd3f https://deploy-preview-7427--carbon-components-react.netlify.app |
336e181
to
485f419
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - controls do not stack @emyarod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No stacking and padding is correct 👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Padding is staying at 16px and no stacking. 👍🏻
Closes #7424
Related #7316
also closes #7444
#7316 modified the pagination component padding while trying to address the issue of vertically stacking pagination controls at certain screen sizes. This PR reimplements the vertical stacking fix while avoiding padding changes to maintain visual consistency
Changelog
Changed
Testing / Reviewing
Confirm that the pagination controls do not stack vertically at any screen size and ensure that the component matches the visual spec