-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Pagination): fix pagination controls line break, fix styles warnings #7316
fix(Pagination): fix pagination controls line break, fix styles warnings #7316
Conversation
Deploy preview for carbon-elements ready! Built with commit b8c2bdf |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit b8c2bdf https://deploy-preview-7316--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Great catch. Does this have an accompanying issue? nbd if no
No unfortunately this does not have an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
…es warnings (carbon-design-system#7316)" This reverts commit 1978c01.
…es warnings (carbon-design-system#7316)" This reverts commit 1978c01.
* Revert "fix(Pagination): fix pagination controls line break, fix styles warnings (#7316)" This reverts commit 1978c01. * fix(pagination): prevent page controls from stacking vertically Co-authored-by: Andrea N. Cardona <andreancardona@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Description
Fix Pagination control buttons line break between 892 - 920 pixel container width.
Before
After
Notes
Most changes are due to sass lint fixes.