Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pagination): fix pagination controls line break, fix styles warnings #7316

Merged
merged 4 commits into from
Nov 23, 2020
Merged

fix(Pagination): fix pagination controls line break, fix styles warnings #7316

merged 4 commits into from
Nov 23, 2020

Conversation

atikenny
Copy link
Contributor

@atikenny atikenny commented Nov 19, 2020

Description

Fix Pagination control buttons line break between 892 - 920 pixel container width.

Before

Screenshot 2020-11-19 at 16 52 01

After

Screenshot 2020-11-19 at 16 52 32

Notes

Most changes are due to sass lint fixes.

@atikenny atikenny requested a review from a team as a code owner November 19, 2020 15:54
@atikenny atikenny requested review from joshblack and dakahn November 19, 2020 15:54
@netlify
Copy link

netlify bot commented Nov 19, 2020

Deploy preview for carbon-elements ready!

Built with commit b8c2bdf

https://deploy-preview-7316--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Nov 19, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit b8c2bdf

https://deploy-preview-7316--carbon-components-react.netlify.app

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Great catch. Does this have an accompanying issue? nbd if no

@atikenny
Copy link
Contributor Author

Works for me. Great catch. Does this have an accompanying issue? nbd if no

No unfortunately this does not have an issue.

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 1978c01 into carbon-design-system:master Nov 23, 2020
@atikenny atikenny deleted the pagination-control-buttons-break branch November 23, 2020 18:51
emyarod added a commit to emyarod/carbon that referenced this pull request Dec 9, 2020
emyarod added a commit to emyarod/carbon that referenced this pull request Dec 9, 2020
kodiakhq bot added a commit that referenced this pull request Dec 10, 2020
* Revert "fix(Pagination): fix pagination controls line break, fix styles warnings (#7316)"

This reverts commit 1978c01.

* fix(pagination): prevent page controls from stacking vertically

Co-authored-by: Andrea N. Cardona <andreancardona@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants