Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-input): switched from outline to border on focus #734

Merged
merged 5 commits into from
May 3, 2018
Merged

fix(text-input): switched from outline to border on focus #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb0528f
fix(text-input): switched from outline to border
marijohannessen Apr 27, 2018
a4ddd06
fix(modal): removed text input
marijohannessen Apr 27, 2018
85affc8
fix(text-input): set outline to none
marijohannessen Apr 27, 2018
6e0bb18
fix(modal): add in missing div
marijohannessen May 2, 2018
62c16ad
Merge branch 'master' into modal/text-input
marijohannessen May 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/components/modal/modal.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,19 @@
</svg>
</button>
</div>

<div class="bx--modal-content">
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aenean id accumsan augue. Phasellus consequat augue vitae
tellus tincidunt posuere. Curabitur justo urna, consectetur vel elit iaculis, ultrices condimentum risus. Nulla facilisi.
Etiam venenatis molestie tellus. Quisque consectetur non risus eu rutrum. </p>
</div>
</div>

<div class="bx--modal-footer">
<button class="bx--btn bx--btn--secondary" type="button" data-modal-close>Secondary button</button>
<button class="bx--btn bx--btn--primary" type="button" data-modal-primary-focus>Primary button</button>
</div>
<div class="bx--modal-footer">
<button class="bx--btn bx--btn--secondary" type="button" data-modal-close>Secondary button</button>
<button class="bx--btn bx--btn--primary" type="button" data-modal-primary-focus>Primary button</button>
</div>
</div>
</div>

<button class="bx--btn bx--btn--danger--primary" type="button" data-modal-target="#modal--danger">Transactional Danger</button>

Expand Down
3 changes: 2 additions & 1 deletion src/components/text-input/_text-input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
}

&:focus {
@include focus-outline('border');
outline: none;
border: 1px solid $brand-01;
}

&:disabled {
Expand Down