fix(text-input): switched from outline to border on focus #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asudoh
reviewed
Apr 27, 2018
There was a problem hiding this comment.
Thanks @marijohannessen for coming up with a quick fix! I’d suggest that we have a quick review with our designers, though I think you may have done this already. Thanks!
src/components/modal/modal.html
Outdated
|
|
||
| <div class="bx--modal-content"> |
There was a problem hiding this comment.
Are we eliminating this <div>?
There was a problem hiding this comment.
Agree, looks like this was edited in error?
There was a problem hiding this comment.
It certainly was 🙂
alisonjoseph
requested changes
May 1, 2018
|
It's been reviewed @asudoh ! |
alisonjoseph
approved these changes
May 2, 2018
asudoh
approved these changes
May 2, 2018
There was a problem hiding this comment.
Thanks @marijohannessen for checking the change with our designers! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #530
Switched from using an outline to using border on focus for the text inputs to prevent the outline from being cut off in a modal in IE11/Firefox.
Changed
_text-input.scssTesting / Reviewing
Make sure that a text input is not cut off on focus anymore when used in a modal in IE11/Firefox.