Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-table): require additional props in certain situations #5682

Merged
merged 6 commits into from
Mar 25, 2020
Merged

fix(data-table): require additional props in certain situations #5682

merged 6 commits into from
Mar 25, 2020

Conversation

tw15egan
Copy link
Collaborator

Closes #5681

Adds in a PropType checker function to only require certain props in certain situations

Changelog

New

  • Helper function to validate if a prop is required or not.

Testing / Reviewing

Ensure Data Table w/ expansion does not throw any console warnings.

@tw15egan tw15egan requested a review from joshblack March 23, 2020 20:00
@tw15egan tw15egan requested a review from a team as a code owner March 23, 2020 20:00
@ghost ghost requested a review from aledavila March 23, 2020 20:00
@netlify
Copy link

netlify bot commented Mar 23, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 81c1c33

https://deploy-preview-5682--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Mar 23, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 81c1c33

https://deploy-preview-5682--carbon-components-react.netlify.com

@tw15egan tw15egan force-pushed the update-prop-types branch from 61ca150 to bff035d Compare March 23, 2020 21:05
@tw15egan tw15egan force-pushed the update-prop-types branch from c0ef028 to 190790c Compare March 24, 2020 16:25
@tw15egan
Copy link
Collaborator Author

@asudoh @joshblack updated and ready for re-review 👍

asudoh
asudoh approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tw15egan for the update!

@joshblack joshblack merged commit 72aca79 into carbon-design-system:master Mar 25, 2020
@aledavila aledavila mentioned this pull request Mar 25, 2020
Closed
@joshblack joshblack mentioned this pull request Mar 31, 2020
Closed
@tw15egan tw15egan deleted the update-prop-types branch April 28, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledavila aledavila aledavila approved these changes

@joshblack joshblack joshblack approved these changes

@asudoh asudoh asudoh approved these changes

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Addition of prop types to TableExpandHeader lead to invalid prop warnings
4 participants
@tw15egan @asudoh @joshblack @aledavila