Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of prop types to TableExpandHeader lead to invalid prop warnings #5681

Closed
joshblack opened this issue Mar 23, 2020 · 0 comments · Fixed by #5682
Closed

Addition of prop types to TableExpandHeader lead to invalid prop warnings #5681

joshblack opened this issue Mar 23, 2020 · 0 comments · Fixed by #5682
Labels
component: data-table package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@joshblack
Copy link
Contributor

joshblack commented Mar 23, 2020

Over in: f3422c4 we introduced prop types for TableExpandHeader, however, this component is typically used without any props in our examples and usage guidance. As a result, individuals who have updated to the latest are seeing prop warnings for now required props that aren't necessarily required.

We should double-check our prop types for this component and see if we need to add conditional validation for these required props for the default use-case of <TableExpandHeader />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data-table package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant