fix(dropdown): Elements overflowing should be hidden but allow scrolling #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
requested changes
Dec 19, 2017
| @@ -112,8 +112,8 @@ | |||
| display: flex; | |||
| flex-direction: column; | |||
| background-color: $ui-01; | |||
| max-height: 50rem; | |||
| overflow: visible; | |||
| max-height: 32rem; | |||
There was a problem hiding this comment.
Could you switch this to 15rem?
1d27718 to
a29c1a3
Compare
tw15egan
approved these changes
Dec 19, 2017
|
Looks great, thanks for the fix! 👍 ✅ |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
…#478) * chore(package): update semantic-release to version 12.2.2 * chore(package): update lockfile https://npm.im/greenkeeper-lockfile
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 8, 2019
…tem#478) * feat(pictograms): added default pictogram of a bee * chore: moved pictograms up the folder structure
designertyler
added a commit
to designertyler/carbon
that referenced
this pull request
Oct 14, 2019
…gn-system#478) * docs(What's new): Add 10.7 to what's new page * Update src/pages/updates/whats-new/index.mdx Co-Authored-By: Connor <connor@ibm.com> * Update src/pages/updates/whats-new/index.mdx Co-Authored-By: Connor <connor@ibm.com> * Update src/pages/updates/whats-new/index.mdx Co-Authored-By: Connor <connor@ibm.com> * Update src/pages/updates/whats-new/index.mdx Co-Authored-By: Connor <connor@ibm.com> * Update src/pages/updates/whats-new/index.mdx Co-Authored-By: Connor <connor@ibm.com> * Update src/pages/updates/whats-new/index.mdx Co-Authored-By: Connor <connor@ibm.com> * Update src/pages/updates/whats-new/index.mdx Co-Authored-By: Connor <connor@ibm.com> * Apply suggestions from code review Co-Authored-By: Connor <connor@ibm.com> * Optimised images with calibre/image-actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #469
Allow dropdown to scale with many items.
OLD:
NEW:
Changed
Adjusted styles to a smaller maximum (50rem was far too long). Up for design discussion. Allowed auto overflow to show scrollbar if content is longer than max-height.