fix(modal): support floating menus in modal #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 ✅ Nothin is broken and works great! |
|
Thanks @marijohannessen for reviewing! This PR should fix #440, too. |
|
Woo! Thanks for adding in these fixes, @asudoh! 👍 ✅ |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
…on-design-system#430) * feat(ClickListener): update ClickListener to not create wrapper node * feat(InnerClickListener): add inner click listener to accompany ClickListener changes
designertyler
pushed a commit
to designertyler/carbon
that referenced
this pull request
Oct 14, 2019
…z-fixes docs: small fixes to chart content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #280.
This PR adds support for floating menus in modal.
Changed
Sass variable for overflow menu
z-index- Now shared with tooltip one, and the value is changed to be bigger than modal's.Testing / Reviewing
Testing should make sure modal, overflow menu, tooltip or card are not broken.