Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow menu is not working in a Modal #280

Closed
kiddove opened this issue Aug 14, 2017 · 7 comments
Closed

Overflow menu is not working in a Modal #280

kiddove opened this issue Aug 14, 2017 · 7 comments

Comments

@kiddove
Copy link

kiddove commented Aug 14, 2017

I'm using an overflow menu inside a modal, but it didn't show up when I clicked. I noticed that overflow menu has a z-index value of 7000, and modal's z-index is 9000. But even I've set large enough z-index to overflow menu, it still won't show up.
image

@theoshu
Copy link
Contributor

theoshu commented Oct 17, 2017

This also happens with regular tooltips in modals.

@tay-aitken
Copy link
Contributor

Hi @theoshu what tasks does the overflow menu contain? We do not recommend using an overflow menu in a modal. That is also not the proper use of the icon. Please tag your designers in this issue if they have further questions on the usage.

@theoshu
Copy link
Contributor

theoshu commented Oct 30, 2017

I was commenting on the tooltips also doing this. Perhaps @kiddove can elaborate.

@kiddove
Copy link
Author

kiddove commented Oct 30, 2017

Hi @tay-aitken, we are using the overflow menu as shown in the picture(the icon is different), to show a list of known servers when user is signing in. Could you please advise us what is the proper way of doing that in the modal if the overflow menu is not recommended?

@tay-aitken
Copy link
Contributor

@kiddove could you please upload screen shots of the whole flow/interaction, so I can better understand what you are trying to achieve?

@kiddove
Copy link
Author

kiddove commented Nov 2, 2017

@tay-aitken , here is the screen shot from our designer's demo site, we are looking for a proper way to show a list of servers within a modal. Now we are using overflow menu.
image

@aagonzales
Copy link
Member

I think this is actually interaction will be replace by a combo box once it its release (it allows for typing and also selection from a dropdown menu). This was not the intended usecase for an overflow menu.

@tay-aitken can share the latest version with you. Tayler I think this is similar to Matthew's usecase.

asudoh added a commit to asudoh/carbon-components that referenced this issue Nov 14, 2017
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
Fixes carbon-design-system#280.

BREAKING CHANGE: use v16.x range for `react` and `react-dom`
designertyler pushed a commit to designertyler/carbon that referenced this issue Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants