Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(project): force react resolutions #3917

Merged
merged 3 commits into from
Sep 5, 2019
Merged

chore(project): force react resolutions #3917

merged 3 commits into from
Sep 5, 2019

Conversation

joshblack
Copy link
Contributor

Closes #3914

Changelog

New

Changed

  • Force resolution of react dependencies to 16.9.0

Removed

@joshblack joshblack requested review from emyarod and a team September 5, 2019 15:41
@ghost ghost requested review from asudoh and removed request for a team September 5, 2019 15:41
@netlify
Copy link

netlify bot commented Sep 5, 2019 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 6b33723

https://deploy-preview-3917--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Sep 5, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 6b33723

https://deploy-preview-3917--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Sep 5, 2019 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 6b33723

https://deploy-preview-3917--carbon-elements.netlify.com

emyarod
emyarod approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleaned and rebuilt locally, stories are all working again. on a side note, after reinstalling and rebuilding I got one more lockfile change, not sure if that's also the case on your end but if so, does it need to be synced?

@joshblack joshblack requested review from a team and removed request for asudoh September 5, 2019 16:47
@ghost ghost requested review from abbeyhrt and tw15egan and removed request for a team September 5, 2019 16:47
@joshblack joshblack requested a review from asudoh September 5, 2019 16:47
@joshblack joshblack merged commit 5285ccb into carbon-design-system:master Sep 5, 2019
@joshblack joshblack deleted the fix/invalid-hooks-in-storybook branch September 5, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 approved these changes

@emyarod emyarod emyarod approved these changes

@abbeyhrt abbeyhrt Awaiting requested review from abbeyhrt

@tw15egan tw15egan Awaiting requested review from tw15egan

@asudoh asudoh Awaiting requested review from asudoh

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid hooks calls in storybook
3 participants
@joshblack @emyarod @jnm2377