Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid hooks calls in storybook #3914

Closed
emyarod opened this issue Sep 5, 2019 · 1 comment · Fixed by #3917
Closed

Invalid hooks calls in storybook #3914

emyarod opened this issue Sep 5, 2019 · 1 comment · Fixed by #3917

Comments

@emyarod
Copy link
Member

emyarod commented Sep 5, 2019

Storybook is failing both in netlify and locally, probably due to the recent package version bumps?

The netlify error doesn't provide much information but building the storybook locally will return invalid hooks call errors for multiple stories

image

rolling back the package versions works as a temporary workaround (v5.1.9 seems to be the last known good version for us)

@joshblack
Copy link
Contributor

@emyarod I vote we just specify a top-level resolutions like:

  "resolutions": {
    "react": "^16.9.0",
    "react-dom": "^16.9.0",
    "react-test-renderer": "^16.9.0"
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants