fix(ComboBox): switch from onInputValueChange to onStateChange #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downshift `v1`'s `onInputValueChange` seems to be called from React state updater function and thus calling `setState()` in `onInputValueChange` handler causes React's "An update was scheduled from inside an update function" warning. Fixes carbon-design-system#2543. Fixes carbon-design-system#3637.
3417836 to
a566b61
Compare
|
Deploy preview for the-carbon-components ready! Built with commit 3417836 https://deploy-preview-3646--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 3417836 https://deploy-preview-3646--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 3417836 |
|
Deploy preview for the-carbon-components ready! Built with commit fa146e9 https://deploy-preview-3646--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit fa146e9 |
|
Deploy preview for carbon-components-react ready! Built with commit fa146e9 https://deploy-preview-3646--carbon-components-react.netlify.com |
emyarod
approved these changes
Aug 5, 2019
asudoh
added a commit
to asudoh/carbon-components
that referenced
this pull request
Jan 6, 2020
This change backs out carbon-design-system#3646 partially given moving `inputValue` state syncing code from `handleOnInputValueChange` to `handleOnStateChange` seems to break IME presumably because the different rendering timing the change causes in-composition string (of IME) overriden by an older value.
asudoh
added a commit
to asudoh/carbon-components
that referenced
this pull request
Jan 6, 2020
This change backs out carbon-design-system#3646 partially given moving `inputValue` state syncing code from `handleOnInputValueChange` to `handleOnStateChange` causes in-composition string (of IME) getting lost, because the different rendering sequence yielded by such change causes Downshift to (temporarily) render an older (stale) value to the `<input>`. Fixes carbon-design-system#4947.
asudoh
added a commit
that referenced
this pull request
Jan 8, 2020
This change backs out #3646 partially given moving `inputValue` state syncing code from `handleOnInputValueChange` to `handleOnStateChange` causes in-composition string (of IME) getting lost, because the different rendering sequence yielded by such change causes Downshift to (temporarily) render an older (stale) value to the `<input>`. Fixes #4947.
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 13, 2020
This change backs out carbon-design-system#3646 partially given moving `inputValue` state syncing code from `handleOnInputValueChange` to `handleOnStateChange` causes in-composition string (of IME) getting lost, because the different rendering sequence yielded by such change causes Downshift to (temporarily) render an older (stale) value to the `<input>`. Fixes carbon-design-system#4947.
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 14, 2020
This change backs out carbon-design-system#3646 partially given moving `inputValue` state syncing code from `handleOnInputValueChange` to `handleOnStateChange` causes in-composition string (of IME) getting lost, because the different rendering sequence yielded by such change causes Downshift to (temporarily) render an older (stale) value to the `<input>`. Fixes carbon-design-system#4947.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downshift's
onInputValueChangeseems to be called from React state updater function and thus callingsetState()inonInputValueChangehandler causes React's "An update was scheduled from inside an update function" warning.Fixes #2543.
Fixes #3637.
Changelog
Changed
onInputValueChangetoonStateChangein our<ComboBox>code for keeping track of user-typed value of<input>.Testing / Reviewing
Testing should make sure our
<Combobox>is not broken.