Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use Chinese IME on ComboBox #4947

Closed
1 of 2 tasks
fred104 opened this issue Jan 3, 2020 · 0 comments · Fixed by #4952
Closed
1 of 2 tasks

Cannot use Chinese IME on ComboBox #4947

fred104 opened this issue Jan 3, 2020 · 0 comments · Fixed by #4952

Comments

@fred104
Copy link

fred104 commented Jan 3, 2020 •
edited
Loading

From certain commit, the Chinese IME is not supported on ComboxBox.

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Is this issue related to a specific component?
Yes, ComboBox.

What did you expect to happen? What happened instead? What would you like to
see changed?
Actual result
User is not able to use IME.
image

Expected result
User should be able to use IME to select words.
image

What browser are you working in?

Chrome, Safari

What version of the Carbon Design System are you using?

carbon-components-react@7.9.0

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

IBM Resilient. We are having code freeze in several days, so I will use carbon-components-react@7.4.0 instead.

Steps to reproduce the issue

Use any zhuyin IME and type 5j/ jp6hk4g4. You will see ㄓㄨㄥ ㄨㄣˊㄘㄜˋㄕˋ, but should be 中文測試.

Additional information

Add labels

Please choose the appropriate label(s) from our existing label list to ensure
that your issue is properly categorized. This will help us to better understand
and address your issue.
asudoh added a commit to asudoh/carbon-components that referenced this issue Jan 6, 2020
@asudoh
fix(ComboBox): bring IME support back
df2513a 
This change backs out carbon-design-system#3646 partially given moving `inputValue` state
syncing code from `handleOnInputValueChange` to `handleOnStateChange`
causes in-composition string (of IME) getting lost, because the
different rendering sequence yielded by such change causes Downshift to
(temporarily) render an older (stale) value to the `<input>`.

Fixes carbon-design-system#4947.
@asudoh asudoh mentioned this issue Jan 6, 2020
Merged
asudoh added a commit that referenced this issue Jan 8, 2020
@asudoh
fix(ComboBox): bring IME support back (#4952)
5b734d8 
This change backs out #3646 partially given moving `inputValue` state
syncing code from `handleOnInputValueChange` to `handleOnStateChange`
causes in-composition string (of IME) getting lost, because the
different rendering sequence yielded by such change causes Downshift to
(temporarily) render an older (stale) value to the `<input>`.

Fixes #4947.
joshblack pushed a commit to joshblack/carbon that referenced this issue Jan 13, 2020
@asudoh @joshblack
fix(ComboBox): bring IME support back (carbon-design-system#4952)
12217d1 
This change backs out carbon-design-system#3646 partially given moving `inputValue` state
syncing code from `handleOnInputValueChange` to `handleOnStateChange`
causes in-composition string (of IME) getting lost, because the
different rendering sequence yielded by such change causes Downshift to
(temporarily) render an older (stale) value to the `<input>`.

Fixes carbon-design-system#4947.
joshblack pushed a commit to joshblack/carbon that referenced this issue Jan 14, 2020
@asudoh @joshblack
fix(ComboBox): bring IME support back (carbon-design-system#4952)
f788410 
This change backs out carbon-design-system#3646 partially given moving `inputValue` state
syncing code from `handleOnInputValueChange` to `handleOnStateChange`
causes in-composition string (of IME) getting lost, because the
different rendering sequence yielded by such change causes Downshift to
(temporarily) render an older (stale) value to the `<input>`.

Fixes carbon-design-system#4947.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ComboBox): bring IME support back asudoh/carbon-components
1 participant
@fred104