feat(typescale): update typescale and mixin #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
reviewed
Oct 11, 2017
| ); | ||
|
|
||
| // ☠️ Deprecated ☠️ | ||
| @mixin font-size($size) { |
There was a problem hiding this comment.
Should we add a @warn to this block that logs that using it is deprecated in V8?
There was a problem hiding this comment.
Good idea! Will add
joshblack
approved these changes
Oct 11, 2017
|
Can you also update the |
1a6ccde to
ba12397
Compare
|
👍 ✅ |
asudoh
added a commit
to asudoh/carbon-components
that referenced
this pull request
Oct 15, 2017
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
…nts (carbon-design-system#357) * Add more detail about setting up webpack for working with our components
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
… is inserted into (carbon-design-system#574) Flatpickr does not change the position of calendar dropdown once it's created, even after the element containing the triggering element (`<input>`) is scrolled. Flatpickr allows specifying the DOM node the calendar dropdown is inserted into, which would work as a way to alleviate such scrolling issue, for example, by specifying a DOM element being scrolled along with the triggering element. This change adds a prop that will be passed along to Flatpickr as such DOM node. Fixes carbon-design-system#357.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update Carbon Components to new typescale
Closes https://github.ibm.com/Bluemix/carbon-issues/issues/348
Added
A new typescale, based on this.
A new
typescalemixin:@include typescale('zeta');Removed
Marked the old
font-sizemixin as deprecated. Will be removed in V9.Changed
Removed all references to
@include font-sizeand replaced with@include typescaleTesting / Reviewing
Make sure no type look wacky? 🙃