Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y - "Danger" buttons are using color alone to indicate danger #574

Closed
arbydev opened this issue Feb 14, 2018 · 2 comments
Closed

a11y - "Danger" buttons are using color alone to indicate danger #574

arbydev opened this issue Feb 14, 2018 · 2 comments

Comments

@arbydev
Copy link

arbydev commented Feb 14, 2018

On the Buttons page there is an example showing "Danger buttons" where their text and border color is red and achieved by using a specific class on the button tag.

http://carbondesignsystem.com/components/button/code

I would suggest not using color alone to indicate warnings or danger. Add an additional danger icon with sufficient contrast in addition so that the danger is relayed more inclusively.

Is this issue related to a specific component?
Buttons

What version of the Carbon Design System are you using?
8.10.1

Add labels

a11y
@koolamusic
Copy link

can this be done ?

@tay-aitken
Copy link
Contributor

Color is the secondary indicator in this case. The text on the button should indicate that the action the user is taken can be dangerous (i.e. delete, remove, etc.).

We will also make sure the button has a danger aria label.

@tw15egan tw15egan mentioned this issue Mar 26, 2018
Merged
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@asudoh @tw15egan
feat(DatePicker): allow specifying the DOM node the calendar dropdown…
7fee43f 
… is inserted into (carbon-design-system#574)

Flatpickr does not change the position of calendar dropdown once it's created,
even after the element containing the triggering element (`<input>`) is scrolled.

Flatpickr allows specifying the DOM node the calendar dropdown is inserted into,
which would work as a way to alleviate such scrolling issue,
for example, by specifying a DOM element being scrolled along with the triggering element.

This change adds a prop that will be passed along to Flatpickr as such DOM node.

Fixes carbon-design-system#357.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@koolamusic @bsonefeld @arbydev @tay-aitken