fix(modal): place aria-hidden on sentinel nodes #15996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
Mar 21, 2024
|
@tay1orjones looks like tests may need to be updated? |
|
@tw15egan I think I'm remembering now why we didn't do this before ... with the
While this approach might be allowable in our view, we can't ship something that's going to pop violations in consumer environments. Eventually the checker may be updated to handle this use case or provide an exception but for now I think we're blocked on this one. For now, the best way around this is via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing some feedback from the Carbon Accessibility Guild to place aria-hidden on the sentinel nodes to ensure they're not read by screenreaders when using virtual cursor mode.
If this is successful,We've confirmed this does fix the issue, so we should port it to all other components that use sentinel nodes, which should fix #14203You can test this change on the modal story of the deploy preview.