Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[a11y]: Modal [all variants] - identifies visually hidden controls #14203

Closed
2 tasks done
guidari opened this issue Jul 12, 2023 · 1 comment
Closed
2 tasks done

[a11y]: Modal [all variants] - identifies visually hidden controls #14203

guidari opened this issue Jul 12, 2023 · 1 comment
Labels
component: modal role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛

Comments

@guidari
Copy link
Contributor

guidari commented Jul 12, 2023

Package

@carbon/react

Browser

Safari

Package version

1.32.0

React version

18.2

Description

VO is reading "Focus sentinel" when arrow down after the "Add" button in all Modal variants

This PR fixed ComposedModal. It might be good taking a look.

Reproduction/example

https://react.carbondesignsystem.com/iframe.html?args=&id=components-modal--with-state-manager&viewMode=story

Steps to reproduce

Arrow down the Modal with the VO active

Suggested Severity

None

Application/PAL

No response

Code of Conduct
@guidari guidari moved this to ⏱ Backlog in Design System Jul 12, 2023
@guidari guidari added the severity: 3 https://ibm.biz/carbon-severity label Jul 13, 2023
@tay1orjones tay1orjones mentioned this issue Mar 18, 2024
Closed
4 tasks
@tay1orjones
Copy link
Member

tay1orjones commented Mar 22, 2024 •
edited
Loading

Closed via

@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Mar 22, 2024
@elycheea elycheea mentioned this issue Jul 27, 2024
Closed
2 tasks
@devadula-nandan devadula-nandan mentioned this issue Sep 6, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: modal role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(modal): place aria-hidden on sentinel nodes carbon-design-system/carbon
3 participants
@tay1orjones @sstrubberg @guidari