fix(UIShell): loss of focus on menu (new) #13796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
francinelucca
approved these changes
May 12, 2023
alisonjoseph
approved these changes
May 15, 2023
tay1orjones
approved these changes
May 15, 2023
SunnyJohal
pushed a commit
to SunnyJohal/carbon
that referenced
this pull request
May 23, 2023
* fix(UIShell): new branch to fix merge problems * test(snapshot): fix snapshots
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13417
Closes #13415
This pull request has been opened as a resolution to the merge conflicts that could not be resolved in the previous pull request. The conflicts happened due to a change from .js to .tsx in the main branch, which impacted the merging process.
I added a new prop to act like a function, so when the focus leaves the SideNav this fucntion will trigger and it will switch the expanded prop in the HeaderContainer
Testing / Reviewing
Switch to mobile view. Open the SideNav by click on the hamburger menu, then enter and leave the SideNav to test the behaviour