-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13417 menu loss of focus #13716
13417 menu loss of focus #13716
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good, and in most cases the menu closes as expected!
I was able to find this case though where the menu does not close as expected.
I click to put focus on the canvas, and then move focus through the menu. I get to the end of the menu, it does not close, and continue moving focus again with tab. You can see the button being focused behind the menu and the page scroll location moving as focus moves between the button and link on the page.
menu.does.not.close.and.focus.of.items.on.page.is.obscured.mov
Fix! I forgot to add the new prop to the stories you were testing. That's why didn't work there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the #13415 When the focus leaves the SideNav and goes to the main content the screen still obscure. I was talking with Taylor about that in the morning. Let me know if that make sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for walking me through that @guidari !
9cac047
to
45a6893
Compare
66dddcd
to
9eae89f
Compare
Closes #13417
Closes #13415
I added a new prop to act like a function, so when the focus leaves the
SideNav
this fucntion will trigger and it will switch theexpanded
prop in theHeaderContainer
Testing / Reviewing
Switch to mobile view. Open the
SideNav
by click on the hamburger menu, then enter and leave theSideNav
to test the behaviour