Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): overflow scroll buttons should not be focusable #13792

Merged

Conversation

tay1orjones
Copy link
Member

Closes #13786

Changelog

Changed

  • add tabindex="-1" to overflow buttons

Testing / Reviewing

  • Go to a tabs story and reduce the window width to trigger the overflow buttons. Run accessibility-checker, the error described in the root issue should no longer be present.

@tay1orjones tay1orjones requested a review from a team as a code owner May 11, 2023 18:47
@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ff83648
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/645e826ace5a9f0008a8a2ba
😎 Deploy Preview https://deploy-preview-13792--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ff83648
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/645e826aea12bc0008c64bba
😎 Deploy Preview https://deploy-preview-13792--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! not seeing the error

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! The violation is gone!

@kodiakhq kodiakhq bot merged commit 85f662c into carbon-design-system:main May 12, 2023
SunnyJohal pushed a commit to SunnyJohal/carbon that referenced this pull request May 23, 2023
…sign-system#13792)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: tab overflow button has aria errors
3 participants