Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[a11y]: tab overflow button has aria errors #13786

Closed
2 tasks done
kglickman opened this issue May 11, 2023 · 1 comment · Fixed by #13792
Closed
2 tasks done

[a11y]: tab overflow button has aria errors #13786

kglickman opened this issue May 11, 2023 · 1 comment · Fixed by #13792
Assignees
@tay1orjones
Labels
component: tabs role: dev 🤖 severity: 2 https://ibm.biz/carbon-severity status: waiting for author's response 💬 type: a11y ♿
Milestone
2023 Q2

Comments

@kglickman
Copy link

Package

@carbon/react

Browser

No response

Operating System

No response

Package version

1.23

React version

16.4

Automated testing tool and ruleset

IBM accessibility checker

Assistive technology

No response

Description

Accessibility checker is reporting error on overflow button of the tabs
Element "button" should not be focusable within the subtree of an element with an 'aria-hidden' attribute with value 'true'

image

WCAG 2.1 Violation

No response

Reproduction/example

see storybook

Steps to reproduce

repro in story book with narrow window so that the tabs overflow.

Code of Conduct
@tay1orjones
Copy link
Member

@kglickman Yes thanks for reporting, I think the buttons should have tabIndex="-1" as they did in v10. We had to rewrite this overflow behavior as part of v11 and must have missed this detail.

@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System May 11, 2023
@tay1orjones tay1orjones moved this from ⏱ Backlog to 🚦 In Review in Design System May 11, 2023
@tay1orjones tay1orjones moved this from 🚦 In Review to 🏗 In Progress in Design System May 11, 2023
@tay1orjones tay1orjones self-assigned this May 11, 2023
@tay1orjones tay1orjones mentioned this issue May 11, 2023
Merged
@kodiakhq kodiakhq bot closed this as completed in #13792 May 12, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Design System May 12, 2023
@tay1orjones tay1orjones added this to the 2023 Q2 milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tay1orjones tay1orjones

Labels
component: tabs role: dev 🤖 severity: 2 https://ibm.biz/carbon-severity status: waiting for author's response 💬 type: a11y ♿
Projects
Design System
Archived in project
Milestone
2023 Q2
Development

Successfully merging a pull request may close this issue.

fix(tabs): overflow scroll buttons should not be focusable tay1orjones/carbon
2 participants
@tay1orjones @kglickman