fix(DataTable): add sorting null values (NEW) #13161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tw15egan
approved these changes
Feb 15, 2023
tay1orjones
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
GitHub is super picky about the syntax to auto-close linked issues. In the PR body it has to be exactly Closes #12696.
I fixed it in the PR body but just wanted to give you a heads up!
|
@tay1orjones thank you I did not know that! |
remolueoend
pushed a commit
to remolueoend/carbon
that referenced
this pull request
Feb 17, 2023
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12696
Changelog
New
Changed
Removed
Testing / Reviewing
My basic findings BEFORE fix
packages/react/src/components/DataTable/stories/shared.jsconst rowsset various values tonull(i.e. multiplenamekeys set to null for column sorting)Storybook > DataTable > Sorting > Default(or anywhere that has sorting enabled)