Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataTable): add sorting null values #13155

Closed
wants to merge 1 commit into from
Closed

fix(DataTable): add sorting null values #13155

wants to merge 1 commit into from

Conversation

jsehull
Copy link
Contributor

@jsehull jsehull commented Feb 15, 2023

Closes #

Fix for Issue #12696

Changelog

New

  • fix ability to sort data even if it has null values in rows

Changed

  • n/a

Removed

  • n/a

Testing / Reviewing

My basic findings BEFORE fix

  • A: single null value in one column did NOT break sorting
  • B: multiple null values in one column DID break sorting
  1. open packages/react/src/components/DataTable/stories/shared.js
  2. under const rows set various values to null (i.e. multiple name keys set to null for column sorting)
  3. open the Storybook site to test in browser: Storybook > DataTable > Sorting > Default (or anywhere that has sorting enabled)
  4. test the sort feature: hover over column headers and cycle clicks at least 3 times (3 different sorting comparison types), but also a bunch of times 💪
  5. confirm both A and B findings (above) sort as expected now

@jsehull jsehull requested a review from a team as a code owner February 15, 2023 15:48
@github-actions
Copy link
Contributor

DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


Jesse Hull seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@jsehull
Copy link
Contributor Author

jsehull commented Feb 15, 2023

I have read the DCO document and I hereby sign the DCO.

@netlify
Copy link

netlify bot commented Feb 15, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 88b3fae
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63ecfeca634cb200085479d6
😎 Deploy Preview https://deploy-preview-13155--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 15, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 88b3fae
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63ecfecaf1361e0008b8f23e
😎 Deploy Preview https://deploy-preview-13155--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jsehull
Copy link
Contributor Author

jsehull commented Feb 15, 2023

@francinelucca same issue as before for DCO, I know what it is, old company email got removed and ended up as a default. I updated it but switched branches or something and it went back to the default.

Maybe I need to recreate this whole PR again. Thoughts?

@francinelucca
Copy link
Collaborator

Hey @jsehull 👋🏼
sorry, I think your best bet here will be to close out and do a new PR with the correct git configurations in place, it's the same thing as last time like you said.

@jsehull
Copy link
Contributor Author

jsehull commented Feb 15, 2023

NEW PR created to address DCO error: #13161

@tw15egan
Copy link
Collaborator

Closing in favor of #13161

@tw15egan tw15egan closed this Feb 15, 2023
@jsehull jsehull deleted the 12696/datatable-sorting-null branch March 2, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants