-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DataTable): add sorting null values #13155
fix(DataTable): add sorting null values #13155
Conversation
DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. Jesse Hull seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account. |
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@francinelucca same issue as before for DCO, I know what it is, old company email got removed and ended up as a default. I updated it but switched branches or something and it went back to the default. Maybe I need to recreate this whole PR again. Thoughts? |
Hey @jsehull 👋🏼 |
NEW PR created to address DCO error: #13161 |
Closing in favor of #13161 |
Closes #
Fix for Issue #12696
Changelog
New
Changed
Removed
Testing / Reviewing
My basic findings BEFORE fix
packages/react/src/components/DataTable/stories/shared.js
const rows
set various values tonull
(i.e. multiplename
keys set to null for column sorting)Storybook > DataTable > Sorting > Default
(or anywhere that has sorting enabled)