Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FluidDatePicker): add FluidDatePickerSkeleton variant #12485

Merged

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Nov 3, 2022

Closes #12404

Adds in FluidDatePickerSkeleton as unstable

Changelog

New

  • FluidDatePickerSkeleton and associated styles

Changed

  • Updates index, snapshots

Testing / Reviewing

Branched off of #12247 .

Go to FluidDatePicker --> skeleton and ensure all skeleton states match the spec

@tw15egan tw15egan requested review from a team as code owners November 3, 2022 16:17
@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 232f4ba
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/636c28ae21c61100093b8e7f
😎 Deploy Preview https://deploy-preview-12485--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 232f4ba
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/636c28ae20b1c0000a23e941
😎 Deploy Preview https://deploy-preview-12485--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 7ac1fa0 into carbon-design-system:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fluid inputs: FluidDatePickerSkeleton implementation
4 participants