-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FluidDatePicker): implement FluidDatePicker
#12247
feat(FluidDatePicker): implement FluidDatePicker
#12247
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
872be26
to
916c836
Compare
@aagonzales I have a lot of the base styles up, but curious how we want to handle I noticed in the spec we have an error state on the entire Would we want to allow both? i.e you could put If we add it to the entire |
@tw15egan yeah we should probably allow just triggering invalid on one side ... I'm not yet sure how that will look visually. We might have to come back to that. Also kind of on the same thread, I forget to spec out |
@aagonzales, so would the invalid outline span the entire input, but just keep invalid text to one input (as-is) for now? Since it's experimental we can come back and refine this interaction as well |
@tw15egan I'm going to talk about this in design crit tomorrow and hopefully get a final answer. The bottom+left is how in forms, we originally said we would treat inline fluid inputs with one invalid state. |
@tw15egan This is what we decided, is it doable? |
Yeah, we should be able to do that; we'll just need to add a prop of |
8a660de
to
b61ea0f
Compare
I believe AVT tests are failing due to the duplicate ids on the stories showcasing all the different warning/error variants. Before merging, these will all be removed and set to a single story |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The componet styles all look correct but there are some bugs in the Playground.
- I'm getting some weird bugs when I switch between Range and Single.
- Switch from single back to range and I can't get the end date calendar menu to open
- Switch from range (with a range selected) to single, the range is still showing when I open the menu.
- When invalid is turned on the width of the inputs grow. The error message should be wrapping and not effecting the width. (Same for warning)
561e51d
to
16b11dc
Compare
@aagonzales That switcher is a bit temperamental, so I switched it to show two components. Also, I set a width on the container, so the component expands downwards now. |
796d3ae
to
1c0a88c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! 🎉 Just some minor suggestions for the playground story
packages/react/src/components/FluidDatePicker/FluidDatePicker.stories.js
Show resolved
Hide resolved
packages/react/src/components/FluidDatePicker/FluidDatePicker.stories.js
Show resolved
Hide resolved
packages/react/src/components/FluidDatePicker/FluidDatePicker.stories.js
Show resolved
Hide resolved
…stories.js Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
…stories.js Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
…stories.js Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go! 👍 ✅
Refs #12125
Closes #12403
Adds in
unstable__FluidDatePicker
andunstable__FluidDatePickerInput
Changelog
New
unstable__FluidDatePicker
componentFluidDatePicker
(_fluid-date-picker.scss
)FluidDatePicker
(FluidDatePicker.stories.js
)FluidDatePicker
Changed
FluidDatePicker
to theFluidForm
storyTesting / Reviewing
Go to
FluidDatePicker
and check out the stories. For now, I've got all the different states in (they will be removed before merging). Ensure all playground controls are correct and stories render as expected.